tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
248 stars 91 forks source link

fix: Multi dimension support for StatsD #2353

Closed SagiVaknin closed 10 months ago

SagiVaknin commented 11 months ago

Fixes #

CLAassistant commented 11 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: SagiVaknin
:x: Sagi Vaknin


Sagi Vaknin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

github-actions[bot] commented 11 months ago

Thank you for your contribution! 🙏 We will review it as soon as possible.

SagiVaknin commented 11 months ago

@tomkerkhove, seems like there is some transient issue with the openTelemetry sink tests. If you can retrigger the pipeline.

We also noticed some issues with the opentelemetry sink in some of our promitor instances, not so familiar with openTelemetry but generally, we noticed that it stops emitting the metrics to the opentelemetry container at some point. started some small investigation but it seems maybe some kind of deadlock? or reaching a stuck state.

tomkerkhove commented 11 months ago

/azp run Promitor CI - Scraper Agent

azure-pipelines[bot] commented 11 months ago
Azure Pipelines successfully started running 1 pipeline(s).
tomkerkhove commented 11 months ago

We also noticed some issues with the opentelemetry sink in some of our promitor instances, not so familiar with openTelemetry but generally, we noticed that it stops emitting the metrics to the opentelemetry container at some point. started some small investigation but it seems maybe some kind of deadlock? or reaching a stuck state.

I haven't heard about this from others but feel free to open an issue for this. Would need to have some more details on the exact problem though.

tomkerkhove commented 11 months ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Sagi Vaknin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

Can you fix the CLA please?

SagiVaknin commented 11 months ago

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. Sagi Vaknin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

Can you fix the CLA please?

Always mixing between my account to the MS one, which I can't sign on. already signed on my personal account

tomkerkhove commented 11 months ago

No worries. Can you try doing a force push with your personal account please? That should fix it

tomkerkhove commented 11 months ago

Looks like we still have 2 users that need to sign the CLA, can you please try again @SagiVaknin?