Closed hkfgo closed 11 months ago
Thank you for your contribution! 🙏 We will review it as soon as possible.
No worries at all, let's keep it in for next release.
Would you mind checking the build failure please?
The test failures look like this
System.Net.Http.HttpRequestException : Error while copying content to a stream.
---- System.IO.IOException : The response ended prematurely.
Which look like a transient failure?
I checked historical release schedules and it seems like there's is one about every two months. If it's possible to release it sooner than the usual schedule, we'd really appreciate it. We at Axon are very interested in testing this code change, as it could resolve many metric gaps we are observing. I don't want to give any pressure though, just want to bring this up as a possibility. Thanks!
/azp run Promitor CI - Scraper Agent
/azp run Promitor CI - Scraper Agent
Hey Tom, this is to fix the mistake I made in this now merged PR. I accidentally let a desired change get overwritten while merging master. This is the bad merge commit in question: bad delta. I don't believe this bad merge will cause any regression, thankfully. It just invalidates the intended fix.
I saw that my merged PR made it to the most recent release. I think this also means you may need to delete it and re-lease a new version?
I am really sorry about my mistake and any trouble it may have caused!