tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
248 stars 91 forks source link

feat: adds PowerBi Dedicated scraping #2368

Closed SurtzSean closed 10 months ago

SurtzSean commented 10 months ago

When implementing a new scraper; these tasks are completed:

Metrics output:

src-promitor.agents.scraper-1            | [03:35:00 INF] Found value 9 for metric azure_powerbi_dedicated_cpu_usage with aggregation interval 00:05:00

Screen Shot 2023-08-26 at 11 32 56 PM

Discovery output:

src-promitor.agents.scraper-1            | [03:35:00 INF] Discovered 1 resources for resource collection powerbi-dedicated.

Relates to https://github.com/tomkerkhove/promitor/issues/339 Relates to https://github.com/promitor/docs/pull/54

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 10 months ago

Thank you for your contribution! 🙏 We will review it as soon as possible.

SurtzSean commented 10 months ago

@tomkerkhove this has been updated to use PowerBidedicated everywhere except for ResourceType

SurtzSean commented 10 months ago

@tomkerkhove I'm unsure about the build failure message as I ran and tested e2e locally. Is it a problem with the pipeline, or PR?

SurtzSean commented 10 months ago

/azp run Promitor CI - Scraper Agent

azure-pipelines[bot] commented 10 months ago
Commenter does not have sufficient privileges for PR 2368 in repo tomkerkhove/promitor
SurtzSean commented 10 months ago

@tomkerkhove would you be able to take a look if you get a moment, or would there be anything more you need prior?

tomkerkhove commented 10 months ago

Nope, should be good - I'll take a look when I can.

tomkerkhove commented 10 months ago

/azp run Promitor CI - Scraper Agent

azure-pipelines[bot] commented 10 months ago
Azure Pipelines successfully started running 1 pipeline(s).
SurtzSean commented 10 months ago

@tomkerkhove I believe I responded to all feedback