tomkerkhove / promitor

Bringing Azure Monitor metrics where you need them.
https://promitor.io
MIT License
250 stars 92 forks source link

Azure SQL scraper: All databases in a server #757

Closed chelnak closed 4 years ago

chelnak commented 5 years ago

Is it possible to enhance the current AzureSQL scraper that is in master to enable all databases within a server to be scraped for a given metric?

Not sure when this feature will make it to the official release but it would be nice as it gives the user the ability to see the same metric across many databases.. reducing config required.

Adding @adamconnelly to this conversation as it seems that the PR was from him.

tomkerkhove commented 5 years ago

We have similar issues open (Storage, Service Bus) but it's not sure yet when we will implement them.

The SQL scraper will be part of v1.1 but this will not make the cut, however, I'm pretty sure we will implement this at some point.

Will have a look at this later on to see how we can leverage this but am open for contributions as well.

chelnak commented 5 years ago

Sounds good. More than happy to PR something if I can get some time.

On Tue, 29 Oct 2019 at 07:15, Tom Kerkhove notifications@github.com wrote:

We have similar issues open (Storage, Service Bus) but it's not sure yet when we will implement them.

The SQL scraper will be part of v1.1 but this will not make the cut, however, I'm pretty sure we will implement this at some point.

Will have a look at this later on to see how we can leverage this but am open for contributions as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomkerkhove/promitor/issues/757?email_source=notifications&email_token=AA42IJXHQ2YH5EL56JAYDGTQQ7PHJA5CNFSM4JF7VLWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECPPHUI#issuecomment-547288017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42IJWB5M3MNAOVRKLT5QDQQ7PHJANCNFSM4JF7VLWA .

adamconnelly commented 5 years ago

@chelnak just adding my thoughts since you tagged me.

I think it sounds like a good idea though, and one that would be useful to us at my work.

tomkerkhove commented 5 years ago

Certainly agree that this is a good idea, but think it's best to do an overall look at how to approach this.

Bottom line - This will come, but we'll have to wait a bit indeed.

chelnak commented 5 years ago

Yep agree too. Thanks the replies

On Fri, 1 Nov 2019 at 09:12, Tom Kerkhove notifications@github.com wrote:

Certainly agree that this is a good idea, but think it's best to do an overall look at how to approach this.

Bottom line - This will come, but we'll have to wait a bit indeed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tomkerkhove/promitor/issues/757?email_source=notifications&email_token=AA42IJXNCYCN6PUKPGGCFS3QRPXGTA5CNFSM4JF7VLWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC2MOLI#issuecomment-548718381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42IJW3BFNIY4XN6FQRXSTQRPXGTANCNFSM4JF7VLWA .

tomkerkhove commented 4 years ago

You can now list multiple DBs for the same metric:

name: azure_sql_database_dtu_consumption_percent
description: "The DTU consumption percentage used by an Azure SQL Database."
resourceType: SqlDatabase
azureMetricConfiguration:
  metricName: dtu_consumption_percent
  aggregation:
    type: Average
resources:
- serverName: promitor-sql-server
  databaseName: promitor-db-1
- serverName: promitor-sql-server
  databaseName: promitor-db-2
- serverName: promitor-sql-server
  databaseName: promitor-db-3
- serverName: promitor-sql-server
  databaseName: promitor-db-4
- serverName: promitor-sql-server
  databaseName: promitor-db-5
- serverName: promitor-sql-server
  databaseName: promitor-db-6

Is it ok for you if we close this issue or do you have more needs?

chelnak commented 4 years ago

Nice! I will test this out. Happy for you to close the issue.

Thank you!

On Thu, 16 Jan 2020 at 07:38, Tom Kerkhove notifications@github.com wrote:

You can now list multiple DBs for the same metric:

name: azure_sql_database_dtu_consumption_percentdescription: "The DTU consumption percentage used by an Azure SQL Database."resourceType: SqlDatabaseazureMetricConfiguration: metricName: dtu_consumption_percent aggregation: type: Averageresources:

  • serverName: promitor-sql-server databaseName: promitor-db-1
  • serverName: promitor-sql-server databaseName: promitor-db-2
  • serverName: promitor-sql-server databaseName: promitor-db-3
  • serverName: promitor-sql-server databaseName: promitor-db-4
  • serverName: promitor-sql-server databaseName: promitor-db-5
  • serverName: promitor-sql-server databaseName: promitor-db-6

Is it ok for you if we close this issue or do you have more needs?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tomkerkhove/promitor/issues/757?email_source=notifications&email_token=AA42IJSWXVI2Y55ZPOY7DFTQ6AFGJA5CNFSM4JF7VLWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJDCTAY#issuecomment-575023491, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA42IJVL3L2XKUBUJJUFX5TQ6AFGJANCNFSM4JF7VLWA .

tomkerkhove commented 4 years ago

Super, thanks!