tomkeuper / BedWars2023

A minecraft minigame where you have to defend your bed and destroy the others. Once your bed is destroyed, you cannot respawn.
GNU General Public License v3.0
39 stars 13 forks source link

Bug invisibility + inventory bug while invisible #288

Open AIGLE25 opened 1 month ago

AIGLE25 commented 1 month ago

Make sure to check before creating a Bug Report

Type of problem

Gameplay Bug

What happened?

https://youtu.be/uZfIIKv9d_4

Expected Behaviour

The armor should become invisible , and the inventory should not bug

How to Reproduce

Get an invis from an other way than potion, and see

Console Log

No response

Errors

No response

Additional Info

No response

AIGLE25 commented 1 month ago

i think i fixed the inventory part by removing this line but now idk how to make the armor invis image

tomkeuper commented 1 month ago

How are you even able to take armor off since bw blocks any click even on your armor slots

AIGLE25 commented 1 month ago

How are you even able to take armor off since bw blocks any click even on your armor slots

i disabled it in the code

tomkeuper commented 1 month ago

What do you mean with in code?

AIGLE25 commented 1 month ago

What do you mean with in code? this code image

tomkeuper commented 1 month ago

So this is not an issue unless you change code right?

AIGLE25 commented 1 month ago

So this is not an issue unless you change code right?

the armor slot unlocked is not the bug , the bug was that it close my inventory automaticaly , so this is causing issue , but i mean, the bug now is the armor not getting invisible when i get invisibility by a other way than a potion

tomkeuper commented 1 month ago

Yeah but if I understand it correctly. the initial bug is caused by something you changed in the code. So if you want the armor slot to be unlocked we need to implement that as a feature correct?

AIGLE25 commented 1 month ago

Yeah but if I understand it correctly. the initial bug is caused by something you changed in the code. So if you want the armor slot to be unlocked we need to implement that as a feature correct?

i dont think its caused by my changes , but i can try with the legacy build

AIGLE25 commented 1 month ago

the armor is still visible on the official build image

and when i clicked on my armor while being invisible , the armor doesn't show anymore image

tomkeuper commented 1 month ago

im not sure how to reproduce this bug. Can you tell me what changes you made to the config/server to produce this result?

AIGLE25 commented 1 month ago

im not sure how to reproduce this bug. Can you tell me what changes you made to the config/server to produce this result?

can you try /effect "player" 14 ?

tomkeuper commented 1 month ago

But the invis effect is something else than drinking the invis potion. Since then there is more logic to it than just applying the invis effect.

AIGLE25 commented 1 month ago

But the invis effect is something else than drinking the invis potion. Since then there is more logic to it than just applying the invis effect.

yeah but i think it's maybe why the armor isn't hided

tomkeuper commented 1 month ago

When you drink an invis potion it does hide the armor

AIGLE25 commented 1 month ago

When you drink an invis potion it does hide the armor

yeah it work , but if you use a throwable invis potion , it will not work

tomkeuper commented 1 month ago

Ahh I see, that would only work if we can register a listener to when potions are applied.

AIGLE25 commented 1 month ago

Ahh I see, that would only work if we can register a listener to when potions are applied.

so it will work if i use a wand or a commad that apply invis effect to a player ?

tomkeuper commented 1 month ago

Not at the moment no, unless the plugin applying these effects will put the player in the correct invis list within bedwars. However maybe we can change that it will also work when an invis effect gets applied outside the bedwars plugin

AIGLE25 commented 1 month ago

Not at the moment no, unless the plugin applying these effects will put the player in the correct invis list within bedwars. However maybe we can change that it will also work when an invis effect gets applied outside the bedwars plugin

would be great

tomkeuper commented 1 day ago

The latest version has quite a lot of invisibility changes. Please let me know your findings!