tomkowz
commented
7 years ago Hi, thank you for your job and time! Will review it soon and merge it to master eventually. Currently on NSSpain so may takie a while.
Best Tomasz
Dnia 13.09.2017 o godz. 15:31 Peyman Khanjan notifications@github.com napisał(a):
Hey @tomkowz ,
I understand the swift3 branch never made it to master which is a shame. It'd be great if we can re-activate this project. It's pretty awesome and I would love it to go forward.
About this pull request, you now have Swift 4 compatibility available + all the changes from swift3 branch.
You can view, comment on, or merge this pull request online at:
https://github.com/tomkowz/Swifternalization/pull/32
Commit Summary
Swift 3 Support. Swift 3 Xcode 8 Beta 6. Fix new test case to support Swift 3 Update podspec, version and provisioning profile Fix for Xcode 8.3 warnings Merge pull request #31 from ArkadiuszBanas/fix/xcode83_warnings Merge branch 'swift3' Version 1.3.3 (Swift 3 Support) Swift 4 Compatibility. File Changes
M Swifternalization.podspec (6) M Swifternalization.xcodeproj/project.pbxproj (39) M Swifternalization.xcodeproj/xcshareddata/xcschemes/Swifternalization.xcscheme (4) M Swifternalization.xcodeproj/xcshareddata/xcschemes/SwifternalizationTests.xcscheme (4) M Swifternalization/Expression.swift (4) M Swifternalization/ExpressionMatcher.swift (4) M Swifternalization/InequalityExpressionMatcher.swift (2) M Swifternalization/InequalityExpressionParser.swift (4) M Swifternalization/InequalityExtendedExpressionMatcher.swift (4) M Swifternalization/Info.plist (2) M Swifternalization/JSONFileLoader.swift (19) M Swifternalization/LoadedTranslation.swift (2) M Swifternalization/LoadedTranslationType.swift (10) M Swifternalization/LoadedTranslationsProcessor.swift (20) M Swifternalization/Regex.swift (32) M Swifternalization/RegexExpressionMatcher.swift (4) M Swifternalization/RegexExpressionParser.swift (4) M Swifternalization/SharedExpressionLoader.swift (2) M Swifternalization/SharedExpressionsProcessor.swift (10) M Swifternalization/Swifternalization.swift (14) M Swifternalization/Translation.swift (4) M Swifternalization/TranslationsLoader.swift (14) M SwifternalizationTests/ExpressionJSONs.swift (6) M SwifternalizationTests/InequalityExpressionMatcherTests.swift (28) M SwifternalizationTests/InequalityExpressionParserTests.swift (2) M SwifternalizationTests/InequalityExtendedExpressionMatcherTests.swift (26) M SwifternalizationTests/InequalityExtendedExpressionParserTests.swift (2) M SwifternalizationTests/JSONFileLoaderTests.swift (8) M SwifternalizationTests/LoadedTranslationsProcessorTests.swift (18) M SwifternalizationTests/NSBundle+TestExtension.swift (8) M SwifternalizationTests/RandomNumbers.swift (18) M SwifternalizationTests/SharedBaseExpressionTests.swift (2) M SwifternalizationTests/SwifternalizationTests.swift (2) M SwifternalizationTests/TranslationJSONs.swift (6) Patch Links:
https://github.com/tomkowz/Swifternalization/pull/32.patch https://github.com/tomkowz/Swifternalization/pull/32.diff — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
Hey @tomkowz ,
I understand the swift3 branch never made it to master which is a shame. It'd be great if we can re-activate this project. It's a pretty awesome library and I would love it to go forward.
About this pull request, you now have Swift 4 compatibility available + all the changes from swift3 branch.