tomkp / react-split-pane

React split-pane component
https://tomkp.github.io/react-split-pane
MIT License
3.23k stars 409 forks source link

Flex is no longer applied to Pane in IE11 after a child dependency update #207

Open SamuelBeliveau opened 7 years ago

SamuelBeliveau commented 7 years ago

bowser, which is a dependency of inline-style-prefixer has been updated to 1.7.0, which breaks the splitpane in IE11.

From what I'm seeing, the flex style is no longer applied to one of the panels.

If I rollback bowser to 1.6.1, it fixes the issue.

I posted here since I don't know at what level the problem is.

nuwanc commented 7 years ago

Not sure I am facing the same issue. for me split pane is not visible in IE11. is it the same to you also?

skarjalainen commented 7 years ago

bowser version 1.6.1 fixed all issues with IE11 for me too.

cdtinney commented 7 years ago

1.6.1 also fixed it for me. I just installed via npm install bowser@1.6.1 --save --save-exact.

Is this an OK approach or is there a better way to override the nested dependency?

StephenMayeux commented 7 years ago

Can confirm. Downgrading bowser to 1.6.1 did the trick for me as well.

nayaabh commented 7 years ago

Downgrading to bowser@1.6.1 in my main project worked for me as well.

georgeOsdDev commented 7 years ago

In my case, 'WebKit' prefix is used for flex style even if I'm using IE 11. I hope #211 will fix this issue.

georgeOsdDev commented 7 years ago

211 with bowser@1.7.0 works well with IE11.

oshidatakeharu at oshida in ~/Project/github/react-split-pane (patch/207●)
$ git branch
  master
* patch/207

oshidatakeharu at oshida in ~/Project/github/react-split-pane (patch/207●)
$ npm ls bowser
react-split-pane@0.1.63 /Users/oshidatakeharu/Project/github/react-split-pane
└─┬ inline-style-prefixer@3.0.6
  └── bowser@1.7.0
sarahwalther commented 7 years ago

This is also an issue for us. We haven't had a chance to test the branch above.

jwickens commented 7 years ago

I can confirm that upgrading to react-split-pane 0.1.65 fixed the issue