tomkp / react-split-pane

React split-pane component
https://tomkp.github.io/react-split-pane
MIT License
3.2k stars 409 forks source link

update react peer dependencies #836

Closed soof-golan closed 5 months ago

soof-golan commented 1 year ago

Hey there 👋

Just wanted to bump this library's peer dependencies so that package managers will be happier about it when installed alongside React 18 (and also 17).

Thanks for creating this useful component

fabioz commented 1 year ago

Any plans to merge this and publish a new version on npm?

I'm on react 17 and I've actually been using react-split-pane for quite a while with it because yarn wasn't checking the deps properly, but now that it does check the deps properly this is a nuisance and ideally I wouldn't like to fork the project and publish a new npm package just for this fix...

wolfoo2931 commented 1 year ago

+1

jony89 commented 10 months ago

Please merge this @AmjadNoor @ellanan @wuweiweiwu @tomkp and publish on npm

tbragaf commented 6 months ago

Any updates on the merge and publish on npm? :) is there anything blocking this merge?

markcorrea commented 5 months ago

Same issue here, upgrading to react-17. side note: weird that npmpeer.dev tells me there's a 2.0.3 version, I installed it and worked... is there such version available?

Screen Shot 2024-03-12 at 15 42 42
wm-rojen commented 5 months ago

Same issue here, upgrading to react-17. side note: weird that npmpeer.dev tells me there's a 2.0.3 version, I installed it and worked... is there such version available?

Screen Shot 2024-03-12 at 15 42 42
soof-golan commented 5 months ago

No longer need this component. Closing this PR to reduce some email chatter 🙏

MaximBG commented 5 months ago

In the meantime just add this to package.json:

"resolutions": { "react-split-pane/react-dom": "17.0.2", "react-split-pane/react": "17.0.2" }