tomkr / embedr

Embedr frontend
Other
2 stars 2 forks source link

Single item page: no way to navigate back to search results #63

Closed paul2keller closed 9 years ago

paul2keller commented 9 years ago

once i am on an image page there is no way to navigate back to the list of serach results (i.e te previous page). the back button gets me back to the homepage (if this was the first search of the visit) or to the previous item page (if this was a subsequent search). The back button should take me back to the search results

tomkr commented 9 years ago

The back button going back to the list of search results is a little complex, since the results are not a real page of their own, but rendered in javascript. A simpler option would be to show the query in the search bar of the viewer page. It can then easily be used to search again from this page. If you can specify which option you would prefer and the requirements I can see what would be the best way to implement this.

mzeinstra commented 9 years ago

Most people won't use the search button again an assume it is their browser history, which you can manipulate in html5 (pushstate), adoption is pretty high only missing opera mini and some older browser (max 7% of all users) and/or store the search query in the anchor.

We want to make it more usable for the end-user, your workaround would not help if you already pressed the back button, but it is a good idea to show the search query in the search bar after search.

tomkr commented 9 years ago

Could you give a list of browsers in which this is currently not working. In both Safari and Firefox the back button from the viewer gets me to the search results grid.

mzeinstra commented 9 years ago

I don't understand, nothing has changed right? If I go to dev.embedr.eu search for rijksmuseum. select one of the items, get to the viewer page and press back, then I want to see the search results I had before. I don't see them now in for example Chrome.

paul2keller commented 9 years ago

for me i get the desired behavior in safari but not in chrome.

On 08 Nov 2015, at 17:55, Maarten Zeinstra notifications@github.com wrote:

I don't understand, nothing has changed right? If I go to dev.embedr.eu search for rijksmuseum. select one of the items, get to the viewer page and press back, then I want to see the search results I had before. I don't see them now in for example Chrome.

— Reply to this email directly or view it on GitHub.

tomkr commented 9 years ago
mzeinstra commented 9 years ago

http://dev.embedr.eu/results/Otto%20Obreen/?license=freely does not work, but http://dev.embedr.eu/results/Otto+Obreen/?license=freely does also http://dev.embedr.eu/results/%22Otto+Obreen%22/?license=freely gives no results.

mzeinstra commented 9 years ago

Als complex queries should give results, like: http://dev.embedr.eu/results/institution:*museum*%20title:*kom/?license=freely

tomkr commented 9 years ago

It uses a query string param now that is encoded. It works for the use cases you provided, try some more to see if it breaks. :8ball:

mzeinstra commented 9 years ago

http://dev.embedr.eu/results/?query=*&license=non-commercial does not yield any results.

As longs as you are at the license part. It would be good to make freely reusable the default, that makes nicer URLs, if non-commercial is not set &license should not appear.

tomkr commented 9 years ago

The omission of the license=freely is available for testing on dev.embedr.eu.

If you could see what is wrong with the non-commercial license search, let me know and we can look into it.

mzeinstra commented 9 years ago

The non-commercial license search is broken due to my mistake in my ingestion script. It omitted non-commercial licenses.

Another item I do see is failing is searches that are not covered also do not receive a result back:

http://dev.embedr.eu/results/?query=wrongfacet%3A*

I expect either 'Incorrect Query.' I prefer the latter

tomkr commented 9 years ago

Can be tested on http://dev.embedr.eu/results/?query=wrongfacet%3A*

mzeinstra commented 9 years ago

Seems to be in order. Closing.