search

tomkr / embedr

Embedr frontend
Other
2 stars 2 forks source link

Metadata needs always have values #68

Closed mzeinstra closed 9 years ago

mzeinstra commented 9 years ago

There are no checks if data exists at: https://github.com/tomkr/embedr/blob/e304fbb46b0e4fd306d14025515b9fac448812b7/app/scripts/components/viewer.jsx#L34

this causes ugly effects in the title bar in the bottom of the viewer:

screen shot 2015-09-22 at 14 20 50

This needs to follow the rules set out in: https://github.com/tomkr/embedr/issues/7#issuecomment-119548981

mzeinstra commented 9 years ago

screen shot 2015-09-22 at 18 13 05

Good implementation, just needs to be lowercase. 'unknown' and creator unknown as per #7

ghost commented 9 years ago

A ' (apostrophe) is not recognised, and the result looks ugly.

screen shot 2015-09-25 at 10 05 40

mzeinstra commented 9 years ago

@Taskamp this is an issue with our ingestion, not the presentation I believe. Would also needs its own ticket