tomkr / embedr

Embedr frontend
Other
2 stars 2 forks source link

Different viewer options for display in embedded images iframe #81

Closed mzeinstra closed 9 years ago

mzeinstra commented 9 years ago

Currently the display of embedded images on sites that are not on embedr.eu display all options that are available on embedr.eu

We want to change that. As embedded images usually don't have access to the full screen its interaction is flawed.

We want to reduce this functionality to only the zoom buttons and a button for embed. pressing this last button would bring the user to the embedr.eu website of the image.

pasted image at 2015_10_09 04_57 pm

I foresee a couple of ways to solve this.

  1. automatically detect when the iframe is not embedded on embedr.eu This is costly and probably has some security risks for the end-user
  2. use a GET variable to communicate which set-up to use. I prefer this one, use a negative variable for external embedding. i.e. do something like http://media.embedr.eu/Rijksmuseum_SK-C-5?f=1 for embedding within embedr.eu and http://media.embedr.eu/Rijksmuseum_SK-C-5 for embedding on external platforms. This keeps the url cleaner for external use and makes the default the version with less functionality.
tomkr commented 9 years ago

This seems to be related to #85. It's a bit clearer to me now. So if I understand correctly the following needs to change:

Since this requires a lot of changes to the media.embedr.eu page, I think it may be smart to move the javascript and css files for the viewer to the embedr.eu server. That way they can be changed without further PRs. So an additional requirement:

Agreed?

mzeinstra commented 9 years ago

I agree with you on the first three. I want to complete the changes to include https://github.com/tomkr/embedr/issues/85

also

As the hosting and load balancer is on our amazon service I think it would not be a good idea to move the static assets to our service. you can do that in a test environment, but not on development.

tomkr commented 9 years ago

Is there a way for me to get access to a development setup of the media.embedr.eu application? Doing PRs in the blind is not a very productive way of working, in my opinion.

mzeinstra commented 9 years ago

I'll see what I can do: https://github.com/klokantech/hawk/issues/74

tomkr commented 9 years ago

There will be three possible configurations for the viewer:

tomkr commented 9 years ago

This can be tested on http://dev.embedr.eu/viewer/

mzeinstra commented 9 years ago

I can confirm that the above described development has been implemented. Closing the ticket.