tomkr / embedr

Embedr frontend
Other
2 stars 2 forks source link

Non-zoomable embeddeable version #85

Closed mzeinstra closed 9 years ago

mzeinstra commented 9 years ago

We have a non-zoomable embeddable image on the roadmap.

472ce3b0-6371-11e5-8428-7ccaf9005c5f Text after tick box should be 'make embedded image zoomable'

When the box it checked it should add a parameter to the iframe src that tells the iframe not allow a zoomable image. Only display the embed button, when clicked the user is directed to image page of the relevant image on embedr.eu

tomkr commented 9 years ago

If I understand correctly there should be an option to have a viewer that can't be zoomed. Something like http://media.embedr.eu/Rijksmuseum_wiki_SK-C-5?zoom=false which only displays the embed button. I don't exactly understand what the embed button is then supposed to do. What is the image page?

I also don't understand why you would want to allow a user to embed a limited version of the viewer? This ticket is a lot of work (since everything that is now baked in has to be made configurable) for little gain in my opinion. And it requires a lot of modifications to the viewer, so it needs to be in a PR on the media.embedr.eu code.

mzeinstra commented 9 years ago

Yes it would require a PR on media.embedr.eu

We want this for UX purposes. I understand that it could be some work. see #81 for further details.

tomkr commented 9 years ago

Closing this, as discussion is taking place at #81 anyway.

mzeinstra commented 9 years ago

This also has an interface element, the checkbox. Is that solved as well?

tomkr commented 9 years ago

Available for testing on dev.ember.eu.

mzeinstra commented 9 years ago

I see that there are some margins that are not followed. I'll try to have an updated css for you by the end of the day.

mzeinstra commented 9 years ago

The User interface seems to be correctly implemented except for one item:

Otherwise you can put this in a pull request to Klokan I believe.

tomkr commented 9 years ago

Changing the checkbox to something non-standard is a lot of work. We skipped it for the radio buttons in the advanced search. Perhaps this can be postponed as well.

mzeinstra commented 9 years ago

I see, ok