search

tomkuijsten / restup

Webserver for universal windows platform (UWP) apps
MIT License
114 stars 48 forks source link

Add default logmanager #112

Open Jark opened 7 years ago

Jark commented 7 years ago

As discussed in #111, this will add a default log manager which will log to the debug console to make it so that we can detect errors in setup and operation easier.

tomkuijsten commented 7 years ago

Looks good, but one small question. Will it ever work? You are using Debug.WriteLine which will be removed during optimization in Release mode. Our nuget package contains only Release mode assemblies. It will work for us, during development of Restup itself, it won't work for consumers of the package.

tomkuijsten commented 7 years ago

Is this something we should still look at?

Jark commented 7 years ago

I'll take a look at this at some point, but probably not to soon. Might have some time this weekend.