search

tomkuijsten / restup

Webserver for universal windows platform (UWP) apps
MIT License
114 stars 48 forks source link

Serialize and deserialize with the correct encoding, fixes #119 #120

Closed Jark closed 7 years ago

Jark commented 7 years ago

This pull request makes sure that any xml documents returned inside the body will get the correct encoding embedded into them.

I've also added tests covering both the serializing and deserializing of xml with different encodings.

Jark commented 7 years ago

@tomkuijsten would you mind reviewing the code?

tomkuijsten commented 7 years ago

I have a look tomorrow, time is a bit limited now. Do you mind refreshing the certificates? That's why the build is failing and no artifacts (nuget packages) are available.

Jark commented 7 years ago

Done, let's see if it works now.

Jark commented 7 years ago

Nope, apparently you have to create a certain type of certificate manually for it to work? I'll investigate further

Jark commented 7 years ago

Will have a look at lunch.

tomkuijsten commented 7 years ago

Looked at the code and ok with me to merge, just update the certificates for the green build and I'll do the merge.

tomkuijsten commented 7 years ago

You might want to update the version numbers (eg 1.0.1-beta1) in the .nuspec file, so we got a valid package name.

tomkuijsten commented 7 years ago

Got some time left, ill merge this and fix the others myself.

Jark commented 7 years ago

@tomkuijsten thanks, out of interest, how did you fix the certificate issue? Did disabling the native toolchain do it?

tomkuijsten commented 7 years ago

Nope, you have to create a new "test certificate" by opening the appxmanifest and don't use a password for it.