tomkyle / negatives-linear-tiff

Converts RAW/NEF/CR2 files into linear TIFF files, using GNU Parallel for maximum speed. Other features: B/W grayscaling, TIF resizing and ZIP compression.
https://tomkyle.github.io/negatives-linear-tiff
Other
7 stars 1 forks source link

Antipattern removal: Rewrite command parameter construction #15

Closed tomkyle closed 7 years ago

tomkyle commented 7 years ago

Currently, the parameter strings for command calls are constructed like this:

args=""
if [ option ]; then
    args+=" --option"
fi

This is antipattern, as deryni points out in a discussion about shellcheck being “too overzealous in regards to unquoted variables”

The better way to go is storing the options in a parameter, like described here: 5. I'm constructing a command based on information that is only known at run time

tomkyle commented 7 years ago

Closed as of 1.1.5