search

toml-lang / toml.io

Source Code for toml.io
https://toml.io
MIT License
42 stars 44 forks source link

add specs/ja/v1.0.0.md for Japanese translation #68

Closed juggernautjp closed 9 months ago

juggernautjp commented 1 year ago

Latest version (v1.0.0) has not translated to Japanese. So, I translated TOML v1.0.0 to Japanese and add specs/ja/v1.0.0.md.

Thank you in advance, if you merge the latest Japanese specs.

cannikin commented 1 year ago

Hello! There's a strange case where the english name of the anchor is appearing in text next to the headings:

image

This isn't present in the other translations, for example Chinese:

image

TonalidadeHidrica commented 1 year ago

I want to take a look at the issue but I cannot yarn dev (on MacOS and node v18). Could you tell me how I can build the website locally? @cannikin

arp242 commented 1 year ago

What problem did you have running it locally @TonalidadeHidrica?

TonalidadeHidrica commented 1 year ago

@arp242 Running yarn dev, I got an error like Error: error:0308010C:digital envelope routines::unsupported. I googled it and figured out that it is happening on webpack and can be temporarily suppressed by NODE_OPTIONS='--openssl-legacy-provider.

Now webpack succeeds, but I got 404 errors no matter what page I access. Am I doing something wrong?

arp242 commented 1 year ago

Yeah, some of the redirects seem broken if only the spec is translated but not the rest of the website.

I don't know why either, I never looked at this repo before today.

But directly accessing e.g. http://localhost:8000/ja/v1.0.0.html should work.

arp242 commented 1 year ago

I guess that's issue #35 (?)

Also: you can click "details" after "Deploy Preview ready!" in the GitHub CI, so seems you don't strictly need to run it locally in the first place: https://deploy-preview-68--toml-io.netlify.app/ja/v1.0.0.html

cannikin commented 1 year ago

@TonalidadeHidrica try a yarn build first, then yarn dev!

TonalidadeHidrica commented 1 year ago

@cannikin Thanks, after running yarn build the built page showed up by directly entering the correct URL! But it seems that yarn dev still does not relfect the updates automatically and I have to run yarn build && yanr serve every single time I make changes... But at least it worked.

cannikin commented 1 year ago

Yeah if you're changing the specs themselves you'll need to do a build, it has to compile them into the HTML for display. But making changes to the site pages are picked up automatically by yarn dev!