Support TOML 1.1 release

toml-rs / toml

Rust TOML Parser

https://docs.rs/toml

Apache License 2.0

684 stars 103 forks source link

Support TOML 1.1 release #397

Open epage opened 1 year ago

epage commented 1 year ago

atm the next toml release contains

Aligning inline tables with inline arrays
Unicode bare identifiers
etc

The unicode one will be a challenge as it might require us to stop using byte parsing and switch back to UTF-8 parsing which would slow us down a good chunk (#219). Its not clear if they reused any existing unicode definitions like xid_continue, so I asked in toml-lang/toml#891

epage commented 1 year ago

Note: this is blocked on the release being out but meant for our tracking of it

wolfv commented 1 year ago

Has there been any progress on the inline-table with multiline support? I looked at some of the history but couldn't find anything yet. I think it's a nice usability improvement in certain cases.

We might be able to spend some time at @prefix-dev if the feature is desired.

epage commented 1 year ago

At this time, I'd rather not be supporting unreleased TOML specs.

The issue for TOML 1.1 spec is toml-lang/toml#928

wolfv commented 1 year ago

And if we would put it behind a feature flag like toml-next or toml-1.1? Would you be open to accept a PR?

epage commented 1 year ago

That could get quite messy maintaining different subsets of the parsers like that.

We'd also need a good way of dividing the conformance tests to handle that.

I would also make it a unstable-toml-1.1 flag because it could have breaking format changes.

Overall, this does not seem worth doing, especially because its not guaranteed that the approved parts of the format will stay as-is