tomleibo / distributedSystems

0 stars 1 forks source link

Termination is not implemented as required #56

Closed hagai-lvi closed 8 years ago

hagai-lvi commented 8 years ago

from the assignment:

We on the other hand, send the termination message with the task @tomleibo what do you think we should do?

tomleibo commented 8 years ago

Revert to the initial implementation. If I remember correctly, we had two different local-to-manager message types. one of them was termination. Then we changed it to one message with termination parameter.

hagai-lvi commented 8 years ago

discussed on phone, better not revert because it was untested

tomleibo commented 8 years ago

Should we also change the implementation of how the local machine waits for statistics file?

TweetsToHtmlConverter converter =ManagerToLocalSqsProtocol.parse(msg.getBody());
                    converter.execute(env.outputFileName);
                    if (env.terminate) {
                        // Expect a statistics file
                        String statsFile = downloadStatsFile();
                        if (statsFile != null) {
                            log.info("Stats file located at " + statsFile);
                        }
                        else {
                            log.info("download statistics file failed.");
                        }
                    }
hagai-lvi commented 8 years ago

Left to do: send the termination message only after the local gets the reply (I think that this is a requirement)