Implement the history navigation buttons - Githubissues

tomlin7 / biscuit

Aesthetic, lightweight code editor with extension support

https://tomlin7.github.io/biscuit

MIT License

189 stars 27 forks source link

Implement the history navigation buttons #396

Open tomlin7 opened 1 month ago

tomlin7 commented 1 month ago

Feature

The history navigations are placed next to breadcrumbs

These shall navigate user's cursor positions

Notes

Implementation of history navigation buttons: src/biscuit/editor/breadcrumbs/history_navigation
Store the history for each editor within the TextEditor or TextEditor.text instance itself: src/biscuit/editor/text
active editor instance is accessible within the history navigation class as self.base.editorsmanager.active_editor. Note that the active_editor.content will be the TextEditor instance and active_editor.content.text will be the Text widget instance.

abhishek-singh0710 commented 1 month ago

Hi, I would like to work on this issue. Could this be assigned to me? Thanks.

tomlin7 commented 1 month ago

Hi, welcome to the community! I hope you have used the cursor history navigation in Visual Studio Code, this issue is about achieving the same functionality. Please let me know in case you need further clarification.

abhishek-singh0710 commented 1 month ago

Thanks, I'll try my best to implement this.

abhishek-singh0710 commented 1 month ago

Hi, I am not sure if this is due to some error on my side but I cannot set up this project on my local machine. At first it was due to a version of python so I used the command poetry env use python313 to use python 3.13.0 Now when I move to the src and do poetry install it gives the following error- Screenshot 2024-10-10 151524 Please help me with this

tomlin7 commented 1 month ago

@abhishek-singh0710 thanks for pointing this out, lock file needed updates for new python version. Now the error has been resolved in #407

abhishek-singh0710 commented 1 month ago

I'm sorry if this is trivial but I am still facing issues for pywinpty Screenshot 2024-10-10 175643

abhishek-singh0710 commented 1 month ago

I've installed Rust and have put cargo in my path variables also

tomlin7 commented 1 month ago

@abhishek-singh0710 this seems to be a common issue as it's listed in many times in the web. I was able to reproduce this issue with python 3.13, but this wasn't causing trouble in 3.12.x.

Since 3.13 is very new, pywinpty hasn't provide the wheels yet. See https://github.com/andfoy/pywinpty/issues/451 I suggest you roll back python to 3.12.x for now, as many libs have not updated yet.

I'm marking this project as unsupported for 3.13 until pywinpty issue gets resolved.

shirsakm commented 1 month ago

pywinpty hasn't provide the wheels yet

Just a heads up, this is the case for google-generativeai as well.

tomlin7 commented 1 month ago

@abhishek-singh0710 issue has been resolved. pywinpty now supports python 3.13.

tomlin7 commented 3 weeks ago

@abhishek-singh0710 Hello there, as the issue is still assigned to you, I would like to know if you are still working on this. Please open a pr if you have worked on this otherwise I can unassign the issue :)