search

tomlion / vim-solidity

Vim syntax file for solidity
MIT License
490 stars 321 forks source link

Change ftplugin to not overwrite user settings #17

Closed CRTified closed 7 years ago

CRTified commented 7 years ago

This change removes code that overwrites user settings for expandtab, tabstop and softtabstop.

This has been criticised in https://github.com/tomlion/vim-solidity/issues/16

asymmetric commented 6 years ago

I think this should actually be reverted, given that the official style guide recommends using 4 spaces.

At the moment, I have to manually configure vim to use 4 spaces, lest I get lots of errors from Solidty linters.

CRTified commented 6 years ago

For this, it needs to be clear whether this repo aims to provide only syntax files or actually additional features related to solidity.

The user that posted #16 stated that a syntax plugin typically should not overwrite these settings if they do not have any syntactical meaning. Granted, the official style guide recommends 4 spaces, but in the end it is up to the developer, and a syntax-only plugin should not modify these changes.

In the end, I think both approaches are fine. If I'd have seen that style guide before issuing the PR, I probably would not have done this.