fayep
commented
10 months ago
[+] Building 257.5s (10/10) FINISHED
=> [internal] load build definition from Dockerfile.debian 0.0s
=> => transferring dockerfile: 44B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load metadata for docker.io/library/rust:1.73-bullseye 1.0s
=> [internal] load build context 0.2s
=> => transferring context: 563.86kB 0.1s
=> [stage-0 1/5] FROM docker.io/library/rust:1.73-bullseye@sha256:1c75c6b98dd762d4de70bc1b165c591c8261 0.0s
=> CACHED [stage-0 2/5] RUN --mount=type=cache,target=/var/cache/apt apt update && apt install -y 0.0s
=> [stage-0 3/5] COPY . /fab-agon-emulator 0.5s
=> [stage-0 4/5] WORKDIR /fab-agon-emulator 0.0s
=> [stage-0 5/5] RUN --mount=type=cache,target=/usr/local/cargo/registry make 255.1s
=> exporting to image 0.6s
=> => exporting layers 0.6s
=> => writing image sha256:307365e4330419d7c2b42ff1bcc4905ba61792779188eba88949380389eba236 0.0s
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
faye@FayesMaxBookPro fab-agon-emulator % docker build -f Dockerfile.debian --platform linux/arm64 .
[+] Building 31.9s (10/10) FINISHED
=> [internal] load build definition from Dockerfile.debian 0.0s
=> => transferring dockerfile: 44B 0.0s
=> [internal] load .dockerignore 0.0s
=> => transferring context: 2B 0.0s
=> [internal] load metadata for docker.io/library/rust:1.73-bullseye 1.8s
=> [stage-0 1/5] FROM docker.io/library/rust:1.73-bullseye@sha256:1c75c6b98dd762d4de70bc1b165c591c8261 0.0s
=> [internal] load build context 0.2s
=> => transferring context: 563.86kB 0.2s
=> CACHED [stage-0 2/5] RUN --mount=type=cache,target=/var/cache/apt apt update && apt install -y 0.0s
=> CACHED [stage-0 3/5] COPY . /fab-agon-emulator 0.0s
=> CACHED [stage-0 4/5] WORKDIR /fab-agon-emulator 0.0s
=> [stage-0 5/5] RUN --mount=type=cache,target=/usr/local/cargo/registry make 28.9s
=> exporting to image 0.9s
=> => exporting layers 0.9s
=> => writing image sha256:ccfe249a9b75ca9f775f25c7cbeb040aaba19529b170aff022ac37002f0cc88c 0.0s
Use 'docker scan' to run Snyk tests against images to find vulnerabilities and learn how to fix them
So, thanks for taking the appropriate bits from my last. Here's another set. PLATFORM is unset on mac, so I've created a variable COMPILER which will get set to g++ or clang depending on $(CXX) --version. It will then set your no-narrowing warnings flag on clang. I think that's the right move - you could be running clang on a different platform - it's getting popular these days. Also, I found a better fix (not hardcoding a path) for the SDL2 location problem. My build worked once I replaced -lpthread with -pthread (as another user has already mentioned) on the test_main build. I haven't included that change. I've also created some Dockerfiles which I used to test these changes on Alpine and debian buster. Happy to contribute those.