search

tommarshall / git-good-commit

Git hook to help you write good commit messages, with no external dependencies.
MIT License
195 stars 33 forks source link

Hooks should return failure when spotting warnings on non-interactive console #17

Closed ssbarnea closed 7 years ago

ssbarnea commented 7 years ago

I discovered that current version of the hook blocks some git (GUI) clients because it prompts for user input.

The current behaviour for the hook is to avoid any interactions on non-tty consoles.

tommarshall commented 7 years ago

Thanks for raising this.

Agree that it makes sense to avoid prompting in non-interactive contexts.