Fix non-interactive usage - Githubissues

tommarshall / git-good-commit

Git hook to help you write good commit messages, with no external dependencies.

MIT License

195 stars 33 forks source link

Fix non-interactive usage #25

Closed tommarshall closed 7 years ago

tommarshall commented 7 years ago

Because:

Currently, the hook will always prompt for user input if warnings are detected.
This prevents usage in non-interactive contexts such as some Git GUI clients and CI.

Notes:

I don't love the test specific FAKE_TTY featuring in the hook itself, but I can't think of a way around this right now and I think the non-interactive support is worth it.

Credit to @ssbarnea for the solution, ref: https://github.com/tommarshall/git-good-commit/pull/18

Fixes #17