Support :set selection=exclusive

inkarkat commented 10 years ago

With this, the '> mark points to after the end of the selection.

Do not change the 'selection' value when the plugin is triggered from visual mode, so that we can grab the original selection.
Simplification: gv can be used instead of "<" . a:type . ">" to restore the original selection. This also deals with blockwise-to-end in all cases.
For the highlighting, the end position must be corrected. Since these are byte indices, we cannot just decrement by 1, but have to subtract the length of the last selected character!

tommcdo commented 10 years ago

I'll have to think about this one a bit more. I like the use of gv, but I'm not totally sold on leaving 'selection' as is.

inkarkat commented 10 years ago

Thanks for merging my other patches so quickly!

I don't understand your concerns; for a 'selection' value of inclusive, nothing changes, and for exclusive, the former behavior is wrong (it swaps one additional character). I do the same in my plugins, e.g. here.

tommcdo commented 10 years ago

Ah, I hadn't noticed that you kept it around for Normal mode. That puts my mind at ease.

Thanks!

tommcdo / vim-exchange

Support :set selection=exclusive #27