fix: additional-css UNIX style path normalization

tommilligan / mdbook-admonish

A preprocessor for mdbook to add Material Design admonishments.

MIT License

176 stars 20 forks source link

fix: additional-css UNIX style path normalization #162

Closed carlocorradini closed 10 months ago

carlocorradini commented 11 months ago

Fix #161

I'm not sure if certain tests (Windows only) are necessary 🤔

tommilligan commented 10 months ago

This looks great, thanks for sending a fix as well. I think we should add a unit test and the Windows platform to CI, which I'll look at doing now. I can see I tried before and then disabled it for some reason, let's find out why!

tommilligan commented 10 months ago

sigh - sorry, I forgot that github behaves weirdly if I try to push to a contributor's PR branch, when it is also the default branch in your fork. (looks to revert your branch, and close this PR automatically)

I've opened a clone of your fix here, with some additional changes on top to add a Windows test for it. Looks good!

If you would like to push the changes back into this PR so you get github kudos for it, please do, otherwise I'll merge that clone PR in a few days.

tommilligan commented 10 months ago

I have also added a note in the contributing guide #164 to remind myself of this behaviour in future

carlocorradini commented 10 months ago

All good for me 🤗 Merge! 🥳