Closed yannickseurin closed 5 months ago
Hi @yannickseurin, thanks for the your contribution and for using mdbook-admonish
.
Definitely agree this is the right behaviour to adopt. I've added back-compatibility so as to not break existing functionality (css-id-prefix
will continue to work, but css_id_prefix
will be used by default). Also added some missing unit tests to catch this type of issue in the future.
Thanks again for taking the time to fix this!
The
AdmonitionDefaults
struct has an attribute to rename all fields in kebab case:This means that the
css_id_prefix
field must actually be declared ascss-id-prefix
in the book.toml file. This is confusing because it is inconsistent with:on_failure
andrender_mode
.