tommilligan / mdbook-admonish

A preprocessor for mdbook to add Material Design admonishments.
MIT License
171 stars 18 forks source link

Hide extra markers displayed in `Safari`. #185

Closed CoralPink closed 1 month ago

CoralPink commented 3 months ago

Hi!

As far as I know, this seems to be a Safari only phenomenon, but I have noticed that extra ▶︎ is being displayed where I have set collapsible.

```admonish info title="example", collapsible=true
Example
```
before

...so why not add the following code to make this disappear?

:is(.admonition-title, summary.admonition-title) {

// …

  &::-webkit-details-marker {
    display: none;
  }

// …

}
after

I don't know if this is the right place... is this the right place? 😅

tommilligan commented 1 month ago

Hi, thanks for the report and the contribution - sorry I didn't get round to doing anything about this for so long.

I updated your branch with what I think should be the right place to fix this - I'm not able to test this locally, would you mind testing and seeing if this still fixes it for you?

CoralPink commented 1 month ago

Hi, I've tried it locally and it seems to be working as expected!

Result:

display-none

Comment out:

comment-out

However, I'm a little worried because I can't find any documentation for -webkit-details-marker when I looked again...

…I hope it's just that I haven't found it... 🫠

tommilligan commented 1 month ago

I found a reference to it here where they suggest exactly what you did in this PR (using display none to hide it), so looks all good to me

CoralPink commented 1 month ago

I see!

Thanks for telling me!😆