search

tommoor / HackerNew

The best Chrome extension to make Hacker News quicker and more useful.
126 stars 29 forks source link

Collapsing changes #11

Closed stevenleeg closed 11 years ago

stevenleeg commented 11 years ago

I've been loving HackerNew since I installed it, but one thing I missed was reddit-like comment collapsing from a plugin I was previously using called Hacker News Collapse.

This pull request implements HN Collapse in HackerNew. It's quite a bit less showy than the current implementation, but I think it does a good job of making comment collapsing fast and easily accessible.

Here's what it looks like before: Before collapse

And after: After collapse

Let me know what you think!

tommoor commented 11 years ago

Hey Steven,

It's probably better to have the collapse functionality over on the left, it does better associate it with the content that you're collapsing. Does this patch do anything other than change the styling, or is it just a visual tweak?

stevenleeg commented 11 years ago

Ah to each his own. It's mostly a visual tweak (check out the diff), so if you don't want to include it feel free to close this.

Keep up the awesome job on HackerNew!

On Tue, Mar 12, 2013 at 1:30 AM, Tom Moor notifications@github.com wrote:

Hey Steven,

It's probably better to have the collapse functionality over on the left, it does better associate it with the content that you're collapsing. Does this patch do anything other than change the styling, or is it just a visual tweak?

Reply to this email directly or view it on GitHub: https://github.com/tommoor/HackerNew/pull/11#issuecomment-14759285

christiangenco commented 11 years ago

+1 on having it on the left side. This is how the Reddit Enhancement suite does things:

Screen Shot 2013-03-13 at 1 16 57 PM

Which is super nice, because to collapse a whole bunch of comments in series you only have to move your mouse horizontally. From a design standpoint, that makes a lot more sense.

tommoor commented 11 years ago

Ah interesting, I definitely feel this is a better direction than the current implementation - perhaps I could pull this and tweak it further so that the collapse is on the left.

stevenleeg commented 11 years ago

I'm stuck in an airport for a bit so I can tweak it and see if you'd like it. Hang tight and I'll get something pushed!

On Wed, Mar 13, 2013 at 2:19 PM, Tom Moor notifications@github.com wrote:

Ah interesting, I definitely feel this is a better direction than the current implementation - perhaps I could pull this and tweak it further so that the collapse is on the left.

Reply to this email directly or view it on GitHub: https://github.com/tommoor/HackerNew/pull/11#issuecomment-14859358

stevenleeg commented 11 years ago

There we are:

Screenshot

Screenshot

tommoor commented 11 years ago

Looking good! How are you finding it functionally? I'll be able to check it out a bit later on... two things:

stevenleeg commented 11 years ago

Glad you like it! I've been using my fork for a couple days now and haven't had any problems with the collapsing.

And yeah I've been having trouble with the retina arrows actually, not sure why. It might be some change I made so I'll look into it when I get home later.

On Wed, Mar 13, 2013 at 3:21 PM, Tom Moor notifications@github.com wrote:

Looking good! How are you finding it functionally? I'll be able to check it out a bit later on... two things:

  • Are the retina arrows not working for you? They look kind of crappy...

- I wonder if we can size the + and - to be the same size - perhaps use an emdash or something longer..

Reply to this email directly or view it on GitHub: https://github.com/tommoor/HackerNew/pull/11#issuecomment-14862833

tommoor commented 11 years ago

Merging this as it's definitely an improvment. It looks like loss of retina was related to the HN update to https the other day and is a separate issue.

christiangenco commented 11 years ago

Nice work @stevenleeg!