search

tommoor / HackerNew

The best Chrome extension to make Hacker News quicker and more useful.
126 stars 29 forks source link

highlighting of followed users broken #31

Closed yanowitz closed 7 years ago

yanowitz commented 7 years ago

Expected: When I follow a user, I would see future instances of their name styled with an orange background.

Actual: There is no visible difference. If I hover over their name, the tooltip shows I'm following them, but I see no styling differences.

I've tried disabling all my other Chrome extensions except this one, and I'm still seeing this behavior.

If I add the highlight class by hand to an hnuser element, I get the expected highlighting.

I don't remember when this started (stopped!) happening, but it's been at least a few months. Current Chrome is 57.0.2987.133, Mac OS 10.12.4

(Thanks for the extension btw, it's very useful!)

tommoor commented 7 years ago

Hey Jason, can you try this:

yanowitz commented 7 years ago

Hmmm. They do indeed! Do I need to refollow everyone? Is there a nice JS snippet I can just paste into console? Sorry to be so lazy about this :(

tommoor commented 7 years ago

No need to refollow, I think there's just a bug where it doesn't display until you renavigate to the page

yanowitz commented 7 years ago

Ah, I have more info.

If I follow the submitter of a post (e.g., https://news.ycombinator.com/item?id=14141190 and click on "alistairSH" [I just picked something on the front page]) and reload, I see that name highlighted.

However, I am not seeing the author of a comment have their name highlighted if I follow them. In fact, I can go to this person's thread listing https://news.ycombinator.com/threads?id=alistairSH and nothing is highlighted, but their submission listing has everything highlighted https://news.ycombinator.com/submitted?id=alistairSH

I would expect to see comments highlighted as well. I believe they used to be.

Cheers.

tommoor commented 7 years ago

Aha!

They probably changed some CSS then, I'll look at that

On Tue, Apr 18, 2017 at 12:03 Jason Yanowitz notifications@github.com wrote:

Ah, I have more info.

If I follow the submitter of a post (e.g., https://news.ycombinator.com/item?id=14141190 and click on "alistairSH" [I just picked something on the front page]) and reload, I see that name highlighted.

However, I am not seeing the author of a comment have their name highlighted if I follow them. In fact, I can go to this person's thread listing https://news.ycombinator.com/threads?id=alistairSH and nothing is highlighted, but their submission listing has everything highlighted https://news.ycombinator.com/submitted?id=alistairSH

I would expect to see comments highlighted as well. I believe they used to be.

Cheers.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/tommoor/HackerNew/issues/31#issuecomment-294947693, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXP8uKyR7Zh1BqTpgefiOjtAN_DiM3rks5rxQjygaJpZM4M_LBd .

tommoor commented 7 years ago

Just published 1.3.2 to the Chrome store, it should auto-update within the next 24 hours 😄

yanowitz commented 7 years ago

thanks. that works!