search

tommoor / emojione-picker

A react emoji picker for use with emojione
http://tommoor.github.io/emojione-picker
MIT License
261 stars 61 forks source link

Error: Cannot resolve 'file' or 'directory' ../node_modules/emojione/emoji.json #34

Closed elado closed 8 years ago

elado commented 8 years ago

Using webpack.

This import is not standard: https://github.com/tommoor/emojione-picker/blob/master/src/picker.jsx#L4

and fails with webpack. If emojione is a dependency (and it is), it should be imported as emojione/emoji.json without node_modules.

I changed it locally and it it indeed loads the json, however there's another bug, hoping this image can show it:

screen shot 2016-08-16 at 11 59 20 am

Reverting to < 1.0.

tommoor commented 8 years ago

Thanks @elado I'll blow away node_modules and take a look at this - I was probably referencing an outdated strategy format in dev would be my guess

elado commented 8 years ago

In dev you might wanna use npm link. Thanks!

tommoor commented 8 years ago

Closed by https://github.com/tommoor/emojione-picker/commit/ec54ce85670af8a63e77ff457c50467182f1dafb

Note: There is a bug in the emojione strategy file which means tones won't appear for some of the emojis until they fix it https://github.com/Ranks/emojione/pull/330. In the meantime I've added a check so that the entire component doesn't fail in this case.