search

tommoor / emojione-picker

A react emoji picker for use with emojione
http://tommoor.github.io/emojione-picker
MIT License
261 stars 61 forks source link

Idea: Separate base/layout styles from "theme" styles #51

Open ahutchings opened 7 years ago

ahutchings commented 7 years ago

I'm using the emoji picker in an application that supports multiple themes. I'm currently pulling in the emojione-picker css file and layering in overrides for each theme. It would be nice if certain elements, such as the search input, could inherit my generic element styles from my app theme without needing the overrides.

One option is to separate the base/layout styles into a standalone file, and put all aesthetic properties such as colors into a separate "default-theme.css" file. This would give users the flexibility to pull in the default theme file only if they want it.

Thoughts?

tommoor commented 7 years ago

I think this is a good idea, although It's a shame they'd need to pull in an additional css file. Perhaps we could have a theme prop that could be set to a falsey value?