search

tommoor / emojione-picker

A react emoji picker for use with emojione
http://tommoor.github.io/emojione-picker
MIT License
261 stars 61 forks source link

Sailfish OS browser doesn't support .includes? #72

Open joyeusenoelle opened 7 years ago

joyeusenoelle commented 7 years ago

2.1.2 resolves an issue with this plugin not searching shortnames. Several Mastodon users are reporting that they are now seeing errors where the Sailfish OS browser doesn't recognize values.keywords.includes() as a function, which prevents them from using Mastodon's Compose tab.

I note that the Sailfish browser is based on an older version of Firefox (38, as opposed to the current release 43).

Is there a way to resolve this, or is the unfortunate answer that this isn't going to work until Sailfish updates their browser architecture?

objectifnul commented 7 years ago

The 'compose' tab used to work fine with Sailfish browser until TootSuite v1.3.x was released and deployed.

joyeusenoelle commented 7 years ago

That appears to be a direct result of 1.3.x being the first version of Mastodon to incorporate emojione-picker 2.1.2+.

tommoor commented 7 years ago

Hmmm, I would have thought that Babel transpiled that if it's incompatible. Could certainly change to use indexOf without too much trouble