search

tommoor / emojione-picker

A react emoji picker for use with emojione
http://tommoor.github.io/emojione-picker
MIT License
261 stars 61 forks source link

change tabIndex to allowable prop #78

Closed stevenmusumeche closed 6 years ago

ahutchings commented 6 years ago

This change in react-virtualized appears to relax the tabIndex requirements to allow null: https://github.com/bvaughn/react-virtualized/pull/818. It has been merged in but not released yet.

It may be worth waiting for (or requesting) a react-virtualized release so we can avoid making the categories container focusable by giving it a tabIndex of 0.

The Emoji tabIndex change appears to be required regardless since the react-virtualized Grid expects a number.

Update: I've asked if the react-virtualized maintainer (@bvaughn) would mind cutting a release to fix this upstream.

bvaughn commented 6 years ago

As mentioned on the issue you referenced, the fix for this was included in the 9.11.0 release this morning.

stevenmusumeche commented 6 years ago

@ahutchings I've updated my PR to back out the previous changes and update the version of react-virtualized used.

ahutchings commented 6 years ago

Let's close this as resolved since no changes are needed in the emojione-picker codebase. The react-virtualized bump should be picked up in any consuming app automatically since it's in the allowed version range in package.json.

stevenmusumeche commented 6 years ago

👍