Table blocks should be surround by newline characters

olipo186 commented 4 years ago

Hi!

This is an improved version of a previous PR that fixes the table syntax issue described here: https://github.com/tommoor/slate-md-serializer/issues/40

Updated renderer to surround table blocks with newline characters
Updated parser to interpret surrounding newline characters (if present) as part of the table block syntax to avoid the creation of excess paragraph nodes
The parser previously skipped the last cell in a table if it was empty (caused by the regexp cap[3].replace(/(?: *\| *)?\n$/, "")). Fixed this and updated test to expect all cells (even empty) to be properly parsed.

olipo186 commented 4 years ago

Hi @tommoor!

I had another look at this issue and dug into your unit tests this time. I'm hoping this PR will be merged. It will make the markdown produced by your editor a little bit more similar to other libs which will improve interoperability.

tommoor commented 4 years ago

Hi @olipo186 - I can definitely agree with the sentiment that the tables produced should be parsable by other markdown implementations.

It looks like the snapshots have changed in this branch which means the Slate output isn't compatible with the previous version though?

Sidenote: You should know that I'm currently working on converting rich-markdown-editor to Prosemirror which will largely make this redundant unless someone chooses to fork and continue development on the Slate version

tommoor / slate-md-serializer

Table blocks should be surround by newline characters #41