search

tommoor / tinycon

A small library for manipulating the favicon, in particular adding alert bubbles and changing images.
MIT License
5.12k stars 278 forks source link

Replace use of 'colour' with 'color' and fix npm package.json #73

Closed gpmcadamold closed 8 years ago

gpmcadamold commented 9 years ago

This pull request replaces the use of 'colour' with 'color' in options, but will actually accept either (to maintain support with previous versions.)

It also fixes some issues with grunt and npm to allow uglifying the code on all platforms.

Addresses issue #65 and allows more contributions.

gpmcadamold commented 9 years ago

Also, the code had a mixture of tabs and spaces - I've included a commit here to make it more consistent using four spaces.

Y'know, because ...

tommoor commented 9 years ago

Wait, you're in the UK? Where's your sense of national pride man? :smile:

gpmcadamold commented 9 years ago

Haha. I was tempted to stick a cheeky console warning in when the American alternative was used.

See also ...

tommoor commented 8 years ago

Thanks for these, I reimplemented as part of a big weekend tidy :smile:

https://github.com/tommoor/tinycon/commit/6a4e131cff0ba08ea863af34ce19cb9b1490468a