tommyblue / smugmug-backup

Makes a full backup of a SmugMug account
MIT License
84 stars 15 forks source link

Add feature to split extension from FileName. #24

Closed briantward closed 9 months ago

briantward commented 2 years ago

:question: What

Allows you to split the extension from the FileName, so that you can set a unique value between the filename and the extension, such as:

FileName-ImageKey.jpg

As a result, images sort in standard lexicographic order by Filename but also maintain extensions. This is useful when there are multiple images in the same gallery or folder with the same file name, and you want to keep all these images in the same folder on your backup. Putting the ImageKey at the beginning of the template causes unordered arrangement of the images. Putting the ImageKey at the end causes issues with applications that use the file extension.

You could solve this with a separate folder per UploadKey as in the existing test scenario in json_structs_test.go but this particular solution allows you to keep the folder structure exactly as it appears in the SmugMug interface.

Updates to README and CHANGELOG pending acceptance.

:hammer: How to test

Tests updated.

:white_check_mark: Checklists

This section contains a list of checklists for common uses, please delete the checklists that are useless for your current use case (or add another checklist if your use case isn't covered yet).

Tests
tommyblue commented 2 years ago

@briantward thanks for your contribution, I'm in vacation until sunday, I'll take a look asap 👋🏼

github-actions[bot] commented 10 months ago

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.