tommycarpi / sentinel-icons

MIT License
31 stars 20 forks source link

Missing an icon #67

Closed aandason closed 6 months ago

aandason commented 6 months ago

Please add the following icons: 1) Flipper Zero (the dolphin) 2) Finnair

tommycarpi commented 6 months ago

Added, use the following "Issuer" names:

aandason commented 6 months ago

Tom, I’m unfamiliar with GitHub (not a coder), could you show me an example using screen-recording if I were to submit a new issue, or request an icon next time? Regards,Ams

On Wed, May 1, 2024 at 23:35, tommycarpi @.***> wrote: Added, use the following "Issuer" names:

Finnair FlipperZero

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

tommycarpi commented 6 months ago

Hello @aandason, don't worry you can just open an issue here, as you did the first time, with the services you are missing an icon and I'll add them ☺️ Cheers

aandason commented 6 months ago

Thanks for adding the Flipper Zero icon promptly, but I’m having another issue, because I attempted to add a little info under the "Issuer", e.g. "Flipper Zero (Forum)", somehow the icon / issuer couldn’t recognise that extra info & the icon was gone again 😂 Ams
On Wed, May 1, 2024 at 23:43, tommycarpi @.***> wrote: Hello @aandason, don't worry you can just open an issue here, as you did the first time, with the services you are missing an icon and I'll add them ☺️

Cheers

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

aandason commented 6 months ago

So is Finnair+ (the + refers to my membership with Finnair) Technically speaking, is it possible / easier to let alone the issuer field whenever additional info was added? Ams

On Wed, May 1, 2024 at 23:49, Ambrose Emerson @.> wrote: Thanks for adding the Flipper Zero icon promptly, but I’m having another issue, because I attempted to add a little info under the "Issuer", e.g. "Flipper Zero (Forum)", somehow the icon / issuer couldn’t recognise that extra info & the icon was gone again 😂 Ams
On Wed, May 1, 2024 at 23:43, tommycarpi
@.> wrote: Hello @aandason, don't worry you can just open an issue here, as you did the first time, with the services you are missing an icon and I'll add them ☺️

Cheers

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

tommycarpi commented 6 months ago

The icons is found by checking the first part of the issuer before any whitespace (you can see an example here).