search

tommyjlong / doorvivint-card

Home Assistant Video Doorbell Card for Vivint Doorbell
Other
19 stars 9 forks source link

WKWebview with WebRTC finally working on iOS 14.3 #2

Closed nanosonde closed 3 years ago

nanosonde commented 3 years ago

Hi!

You are writing that the you never got it to work on Home Assistant Companion App for iOS, right? Have you tried latest iOS14.3 version?

There have been some improvments in WkWebview component: https://blog.bitsrc.io/ios-14-3-brings-webrtc-to-wkwebview-closing-gap-on-ios-accessibility-90a83fa6bda2 https://bugs.webkit.org/show_bug.cgi?id=208667 https://developer.apple.com/forums/thread/669011 https://webkit.org/blog/11353/mediarecorder-api/

Concerning audio: I can see here that the app add the necessary record to request the camera: https://github.com/home-assistant/iOS/blob/master/Sources/App/Resources/Info.plist#L603

However, I do not see NSMicrophoneUsageDescription in the file. Thus, the webview in the app will not be able to request microphone access.

You can test it here: https://webrtc.github.io/samples/

nanosonde commented 3 years ago

Good news! The companion app for iOS has added the necessary string to Info.plist yesterday: https://github.com/home-assistant/iOS/pull/1323

nanosonde commented 3 years ago

Just tested the card with the fixes from issue #3. Now it is working with the latest Home Assistant iOS app and two-way audio.