tommyod / KDEpy

Kernel Density Estimation in Python
https://kdepy.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
584 stars 90 forks source link

Fix version duplication #135

Closed tommyod closed 1 year ago

rolandwalker commented 1 year ago

Hi!

Is removing the dependencies in pyproject.toml https://github.com/tommyod/KDEpy/pull/135/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L4-L14 meant to reduce duplication with requirements.txt?

tommyod commented 1 year ago

No, the idea was to reduce duplication with respect to setup.py.

I'm not completely steady on pyproject.toml vs setup.py, but my interpretation of requirements.txt is as developer requirements, while pyproject.toml / setup.py is user requirements. Let me know if my interpretation is wrong or if you would've set up these files differently. Happy to merge PRs on this issue.