search

tommyvernieri / cellar-view

Automatically exported from code.google.com/p/cellar-view
0 stars 0 forks source link

Price and bin numbers are truncated for long appellations #1

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

1. Include a wine with an appellation like "Australia, South Australia, 
Limestone Coast, Coonawarra"
2. Load the wine list page on a monitor that is not more than 1280 pixels wide.

What is the expected output? What do you see instead?

I expected to see the full price and bin information. I saw the bin 
information, but the price seems to be hidden behind the next column.

Original issue reported on code.google.com by tommy.ve...@gmail.com on 5 Sep 2011 at 6:16

GoogleCodeExporter commented 9 years ago

Original comment by tommy.ve...@gmail.com on 6 Sep 2011 at 4:23

GoogleCodeExporter commented 9 years ago 
Currently, the locale text does not permit word wrapping. This is in an effort 
to keep the appellation together on the second line when it would otherwise be 
wrapped in the middle of the appellation but still take up only two lines.

As an example, the first layout is preferred over the second.

    2009 Chasseur Chardonnay Lorenzo 
    (Sonoma County, Russian River Valley)

    2009 Chasseur Chardonnay Lorenzo (Sonoma 
    County, Russian River Valley)

However, this results in the issue where price and bin numbers are truncated, 
since long locales do not wrap at all (as seen in the next example).

    2003 Antolini Amarone della Valpolicella Classico 
    (Italy, Veneto, Valpolicella, Amarone della Valpolicella Classico)

One solution would be to allow the appellation to wrap and get the layout from 
the first example, with "(Sonoma" on the first line and "County..." on the 
second line.

Another solution would be to only allow word wrapping after a comma in the 
locale. Here is an example of the current behavior and the behavior that would 
result from a change like this.

    2005 Château de Reignac (Bordeaux, Bordeaux 
    Supérieur)

    2005 Château de Reignac (Bordeaux, 
    Bordeaux Supérieur)

A final solution would be to use a "text-wrap: avoid;" CSS rule for the local 
instead of its current "white-space: nowrap;" rule. However, text-wrap is not 
currently implemented by any browsers.

http://www.w3.org/TR/2011/WD-css3-text-20110215/#wrapping

Original comment by tommy.ve...@gmail.com on 21 Nov 2011 at 10:16

GoogleCodeExporter commented 9 years ago 
See also: 
http://stackoverflow.com/questions/5392853/html-css-denoting-a-preferred-place-f
or-a-line-break

Original comment by tommy.ve...@gmail.com on 21 Nov 2011 at 10:24

GoogleCodeExporter commented 9 years ago 
For the Amarone example above, this would be the desired layout.

    2003 Antolini Amarone della Valpolicella Classico 
    (Italy, Veneto, Valpolicella, Amarone della Valpolicella 
    Classico)

Original comment by tommy.ve...@gmail.com on 21 Nov 2011 at 10:27