search

tomneedham / oc-drawio

Create edit and share Draw.io diagrams in ownCloud
https://marketplace.owncloud.com/apps/drawio
GNU General Public License v2.0
4 stars 2 forks source link

Corrected embed link #15

Closed davidjgraph closed 4 years ago

davidjgraph commented 4 years ago

Using www.draw.io redirects to app.diagrams.net, which doesn't allow iFrame embedding. embed.diagrams.net is the correct URL to use.

alep84 commented 4 years ago

Thanks for updating the URL. Anyway, after applying your fix I got the following message: XML Parsing Error: unclosed token Location: https://embed.diagrams.net/?embed=1&picker=0&stealth=1&spin=1&proto=json&ui=minimal Line Number 1, Column 1:

davidjgraph commented 4 years ago

That sounds like the default moaning Firefox always throws out, have you tried Chrome? Doesn't FF give that with www.draw.io? If embed=1 is always the first parameter we could pick that up and forward to embed.diagrams.net, is that the case?

alep84 commented 4 years ago

Yes, same behaviour with www.draw.io (Firefox), the problem may be somewhere else. Chrome same result, not working.

fellipecamara commented 4 years ago

Hi, even after fix the address, my OwnCloud (10.0) doesnt open the draw app. Actually when i try to open a new file, the draw opens, but with no option enabled. When i try to open a file created before, the draw opens with no options enables and showing the loading gif forever. I get no error in console and apache logs as well.. I'm without clues...

davidjgraph commented 4 years ago

Try that as well, I've never run this project, I don't actually know all the locations I need to update.

alep84 commented 4 years ago

Thanks for the fix! Seems to work now

fellipecamara commented 4 years ago

Thanks! Now is working pretty good as always!