search

tomnelson / jungrapht-visualization

visualization and sample code from Java Universal Network Graph ported to use JGraphT models and algorithms
Other
48 stars 7 forks source link

JUnit 5 Migration #26

Closed syoon2 closed 8 months ago

syoon2 commented 8 months ago

This PR migrates all JUnit 4-based tests to JUnit 5.

tomnelson commented 8 months ago

I had to use a newer version of maven to have the tests pass locally. I assume the github actions build is failing now for the same reason.

tomnelson commented 8 months ago

Thank you for your Pull Request. It builds and tests successfully on my local machine, after I updated the maven version I am using. I have not found a way to make this work in github actions, so the automatic build always fails. Do you have any ideas for a fix? The @BeforeEach annotated methods are not being executed. If you have no ideas, I may revert this PR in the near future. Let me know.

syoon2 commented 8 months ago

Writing a follow-up PR.