search

tomnomnom / gron

Make JSON greppable!
MIT License
13.83k stars 327 forks source link

Add ldflags to 'go build' cmd to bring back version number #100

Open dotcs opened 2 years ago

dotcs commented 2 years ago

In v0.7.1 the -ldflags "-X main.gronVersion=${VERSION}" argument to the go build cmd has been removed.

This PR reverts this change and re-introduces the flag to show the correct version string in the binary.

https://github.com/tomnomnom/gron/blob/13561bd6339bff18ba571e62313b3f5a6db00111/main.go#L47-L49

Closes #97

rperce commented 2 years ago

@tomnomnom wanted to bring this one to your attention, if you missed it—it closes the bothersome (to me) #97 and should be pretty straightforward!