search

tomoakin / RPostgreSQL

Automatically exported from code.google.com/p/rpostgresql
64 stars 19 forks source link

[feature request] implement connection services #90

Open itcarroll opened 7 years ago

itcarroll commented 7 years ago

Quoting from the current docs:

The connection service file allows libpq connection parameters to be associated with
a single service name. That service name can then be specified by a libpq connection,
and the associated settings will be used.

The implementation should allow creating a connection with

dbConnect(PostgreSQL(), service = 'xyz')

where the (by default) ~/.pg_service.conf file contains an entry for xyz that centrally stores all the connection parameters.

Happy to start work on a PR.

itcarroll commented 7 years ago

Oh, loophole!

dbConnect(PostgreSQL(), dbname = 'postgresql://@/?service=xyz')

Achieves what I wanted, if inelegantly. I still think it would be good to provide the service parameter as its own argument, so I'll leave my issue open.

AmyMikhail commented 5 years ago

Not sure if this is referring to RStudio preview versions >= 1.2.1?

I have installed the preview version and was excited to try out the new SQL database 'connection' feature, only to discover that this has to be set up for each package that makes connections to databases and isn't yet automatically detected for RPostgreSQL.

The FAQ for the preview version says that package authors need to implement the RStudio connections contract.

Would it be possible to implement this for the RPostgreSQL package? This new feature in RStudio would be really useful for creating new queries.

itcarroll commented 5 years ago

No, this feature request isn't about RStudio "connections". I'd suggest you open a separate issue, or switch to the RPostgres package (which is what I did).

On Mon, Feb 4, 2019, 4:49 PM AmyMikhail <notifications@github.com wrote:

Not sure if this is referring to RStudio preview versions >= 1.2.1?

I have installed the preview version and was excited to try out the new SQL database 'connection' feature, only to discover that this has to be set up for each package that makes connections to databases and isn't yet automatically detected for RPostgreSQL.

The FAQ for the preview version says that package authors need to implement the RStudio connections contract https://rstudio.github.io/rstudio-extensions/connections-contract.html.

Would it be possible to implement this for the RPostgreSQL package? This new feature in RStudio would be really useful for creating queries.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tomoakin/RPostgreSQL/issues/90#issuecomment-460426756, or mute the thread https://github.com/notifications/unsubscribe-auth/ADOiHdZyaO7O7mfOgsI5gMUs16G-7KOFks5vKKrpgaJpZM4O38Tj .