search

tomoakley / freemeals.uk

MIT License
10 stars 10 forks source link

(Refactor) Container shared logic #26

Closed kurt-culley closed 3 years ago

kurt-culley commented 3 years ago

I think there's some opportunity to refactor some of the logic shared by the list and map containers, mainly around data fetching (perhaps could be moved out to a hook?)

tomoakley commented 3 years ago

I've added a data provider context component in #29, so that we're not duplicating the code for fetching the data. Let me know what you think.

kurt-culley commented 3 years ago

Hey I like what you've done so far, it's a nice improvement! I've left a couple comments on the pr for things to consider 🙂

tomoakley commented 3 years ago

Done (for now)