search

tomoakley / freemeals.uk

MIT License
10 stars 10 forks source link

Geolocated results are slow to resolve, reload the page #31

Closed tomoakley closed 3 years ago

tomoakley commented 3 years ago

All of the results load, and then a few seconds later the geolocated results (if the user has permitted access to their location) will cause the page to reload. Would be great if it could be much smoother - i.e not showing/requesting all results and not reloading the page.

elstob commented 3 years ago

On it

elstob commented 3 years ago

The geolocation reload will be better implemented after the container refactor work in progress is done The only way I can see to block a refresh post geolocation is to set a flag when react-geolocated fires it's onSuccess/onError callbacks. If we have that flag we can block data loading until we know a user has been through the geolocation flow/doesn't have access to the geolocation API.

tomoakley commented 3 years ago

@elstob the refactoring is done and the new design is in. So a general improvement in the data fetching would be useful I think

tomoakley commented 3 years ago

I think for now this can be closed.