search

tomoakley / freemeals.uk

MIT License
10 stars 10 forks source link

Mobile scrolling issues #70

Closed domcoleman closed 3 years ago

domcoleman commented 3 years ago
  1. The ProviderList component is still scrollable whilst viewing a Provider once the address bar is no longer visible.
  2. The view on mobile is slightly too wide (on my Pixel 2), causing the page to need to be scrolled horizontally to press the close button.

screen-20201026-143354

domcoleman commented 3 years ago

Will make a PR with fixes later if there are no pending design changes?

tomoakley commented 3 years ago

no big design changes now. I think in #57 @danvernon is going to improve the Selected Pane, not sure if he's going to include this. tbh I'd just go for it if you have the time

tomoakley commented 3 years ago

I've fixed (some of) the responsive issues, but there's probably some cases I didn't spot.

domcoleman commented 3 years ago

I saw you'd made a commit yesterday with some of the changes so figured I'd leave it and test when you were done. All seems to be working fine now!