Refactor/data handling - Githubissues

lmjcbs commented 3 years ago

Resolves #63

tomoakley commented 3 years ago

I'm a bit wary about merging this as it changes a lot of very important stuff, and without any tests it's tough to ensure it all works as it should (even though location wasn't working before). However - it seems to work fine according to the deploy preview. Thanks for working on it though!

Could you change the target from develop to master? the deploy preview gives us what we need in terms of verifying - although it would be handy if you could pull the latest from master to ensure it all works

tomoakley commented 3 years ago

two things I've noticed - but I don't think they're blockers:

if a location is selected, and I enable geo mode or enter a postcode, it doesn't show the right results
would be great if the 'showing x results closest to you' could change to 'showing x results near ' when a location is selected. Also if it could change when a postcode (rather than geo) is entered to 'showing x results near ' that'd be really cool

again, neither are blockers to merging this

tomoakley / freemeals.uk

Refactor/data handling #72