include more detailed results info

tomoakley / freemeals.uk

MIT License

9 stars 10 forks source link

include more detailed results info #82

Closed lmjcbs closed 3 years ago

lmjcbs commented 3 years ago

I'm not sure it's possible to have all of the detailed messages, I found that adding more detailed results for

All providers across the country
Specific Location closest to ${selectedLocation}
Valid Postcode Search closest to ${selectedPostcode}

Meant that one of these conditions would always be met, invalidating

Geo closest to you

I believe it's down to preference which one you want to overwrite the others with. I've opted to omit the Geo case.

Let me know your thoughts.

lmjcbs commented 3 years ago

I've added the switch statement changes, I managed to get that working on my end. There's also a remaining edge case I can't seem to figure out.

If you enter a valid postcode, the results info displays the postcode. If the user removes a character, invalidating the postcode, the postcode reverts to null, which is displayed in the results info until the user removes the invalidated postcode all together.

tomoakley commented 3 years ago

awesome, I think that's much better 👏