tomography / XRFtomo

a repository for xray fluorescence data processing
Other
3 stars 6 forks source link

readthedocs compile error #19

Closed decarlof closed 5 years ago

decarlof commented 5 years ago

@aglowacki build the docs gives an error in the xfluo.models.element_table module at

def headerData(self, section: int, orientation: QtCore.Qt.Orientation, role: int = ...): ^ SyntaxError: invalid syntax

can you please have a look?

decarlof commented 5 years ago

@aglowacki for now I commented out the call

aglowacki commented 5 years ago

How are you building the docs? When I run make html I get a segfault instead of an error message.

decarlof commented 5 years ago

I use sphynx (https://docs.readthedocs.io/en/latest/intro/getting-started-with-sphinx.html)

once is installed you

cd docs make clean make html

then you can inspect the result opening with the browser the built folder

francesco

On May 3, 2019, at 21:52, Arthur Glowacki notifications@github.com wrote:

How are you building the docs? When I run make html I get a segfault instead of an error message.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

aglowacki commented 5 years ago

I had to update my sphinx version . I was able to build without the error you stated above. I t says build finished.

Are you still getting the error?

decarlof commented 5 years ago

I am not getting the error because I commented out xfluo.models.element_table module at

def headerData(self, section: int, orientation: QtCore.Qt.Orientation, role: int = ...):

aglowacki commented 5 years ago

Please see pull request #31

decarlof commented 5 years ago

solved

decarlof commented 5 years ago

for the record this is the readthedoc build that failed with the syntax error at

def headerData(self, section: int, orientation: QtCore.Qt.Orientation, role: int = ...): ^ SyntaxError: invalid syntax

aglowacki commented 5 years ago

@decarlof Looking at that link it looks like read the docs is defaulting to python 2.7 line 5: python2.7 -mvirtualenv --no-site-packages --no-download /home/docs/checkouts/readthedocs.org/user_builds/xfluo/envs/

Looking at http://blog.readthedocs.com/python-36-support/ https://docs.readthedocs.io/en/stable/config-file/v1.html

I think if we add the version 3.6 under the python tag if will use python 3.6 and should pass.

I don't know to test the read the docs build

decarlof commented 5 years ago

I just rebuilt your (@aglowacki) fork here and readthedocs is using python3.7 so I would say that some other change (not the recent meta.yaml) fixed the problem. Perhaps the change is setup.py by @sichendart here ?

aglowacki commented 5 years ago

If it works from a previous fix then I'm going to close the issue.